Fix: #455 Use proper detailPanel callback signature when detailPanel is an array of callbacks #468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#455
Description
Fixes wrong type. The proper type when using callback in multiple detail panel is
(rowData: RowData) => ...
instead of({rowData} => {rowData: RowData})
as types suggest.This problem can be seen when we modify the example of multiple detail panels to:
Then the result of console.log is
not
This is probably a rare case when someone needs rowData outside of detailPanel render(), but then all they can do is to suppress type error.
It may also be that we want ({rowData: RowData}) => .. to be passed here as is it is with render(). If so I propose setting up another PR for that