Remove obsolete getContentAnchorEl prop from LookupFilter MenuProps for MUIv5 #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In MUI v5, the `getContentAnchorEl` prop was removed https://mui.com/material-ui/migration/v5-component-changes/#remove-getcontentanchorel-prop So with this prop still being supplied via MenuProps currently, it leads to the following console error whenever you click on a filter menu from @material-table/core: > Warning: React does not recognize the `getContentAnchorEl` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `getcontentanchorel` instead. If you accidentally passed it from a parent component, remove it from the DOM element. The prop isn't doing anything anymore, and the filter menu still works without it, so it seems it should just be removed in the MUI v5 variant of @material-table/core.
Domino987
approved these changes
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
n/a
Description
In MUI v5, the
getContentAnchorElprop was removed https://mui.com/material-ui/migration/v5-component-changes/#remove-getcontentanchorel-propSo with this prop still being supplied via MenuProps currently, it leads to the following console error whenever you click on a filter menu from @material-table/core:
The prop isn't doing anything anymore, and the filter menu still works without it, so it seems it should just be removed in the MUI v5 variant of @material-table/core.
Related PRs
n/a
Impacted Areas in Application
List general components of the application that this PR will affect:
LookupFilterAdditional Notes
This should only be done in the MUI v5
nextbranch, it seems.