Fix dummy app's npm install failing on M1 Macs
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to solve the nodegyp situation, just bumped up the NPM package versions to match the gem versions and that got rid of the node-sass dependency and started picking up on using sass instead.
In order to use nokogiri on ARM architecture with an alpine image, we need gcompat as per this thread: https://stackoverflow.com/a/71014474
jonasjabari
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 25: Running
npm installon dummy app fails to buildChanges
@rails/xxxJS packages in dummy app to match their Rails gem counterparts.gcompatfor nokogiri capabilities on M1 Macs.Notes
@rails/webpacker@5.2.1was the presumed culprit of this as per inspection of the package-lock.Also noticed that the JS packages for the Rails gem counterparts were out-of-sync (Rails 7.x gems with
rails@6.xJS package versions).When running
./bin/webpacknow, I noticed there's an issue that pops up listing:Upon a bit of research, it seems it's an actual Sass/Bootstrap problem and should be addressed in Bootstrap v5.2.3, as mentioned here . Perhaps this should be an update taken care of an a separate issue (bumping the Bootstrap version. I don't know what the compatibility rules are when it regards to this and an open source project.). Have you seen this in any of your branches/projects? @jonasjabari I haven't seen it in any client projects come up using matestack-ui-bootstrap with webpacker or with importmap.