Fixes issue #23

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 1.5.0
+
+### Minor Changes
+
+- Fixes https://github.com/mu-io/ts-japi/issues/23
+
 ## 1.4.0
 
 ### Minor Changes

package.json

@@ -1,6 +1,6 @@
 {
  "name": "ts-japi",
- "version": "1.4.0",
+ "version": "1.5.0",
  "description": "A highly-modular (typescript-friendly)-framework agnostic library for serializing data to the JSON:API specification",
  "main": "lib/index.js",
  "scripts": {

src/utils/serializer.utils.ts

@@ -16,19 +16,21 @@ export async function recurseRelators(
    for (let i = 0, len = relators.length; i < len; i++) {
     const relator = relators[i];
     const relatedData = await Promise.all(data.map(relator.getRelatedData));
-    const newData: any[] = [];
     const newRelators = relator.getRelatedRelators();
+    const newData: any[] = [];
     await Promise.all(
-     relatedData.flat().map(async (datum) => {
-      if (datum !== null) {
+     relatedData
+      .flat()
+      .filter((d) => d !== null)
+      .map(async (datum) => {
        const resource = await relator.getRelatedResource(datum);
        const key = resource.getKey();
        if (!keys.includes(key)) {
-        included.push(resource);
         keys.push(key);
+        included.push(resource);
+        newData.push(datum);
        }
-      }
-     })
+      })
     );
     if (newData.length > 0 && newRelators) {
      queue.push([newData, Object.values(newRelators)]);

test/issue-23.test.ts

@@ -0,0 +1,43 @@
+import { Serializer, Relator } from "../lib";
+import { inspect } from "util";
+
+describe("Serializer", () => {
+ it("Should traverse a depth > 1", async () => {
+  type A = { id: string; prop: string };
+  type B = { id: string; prop: string };
+  type C = { id: string; prop: string };
+
+  const counters = { AtoB: 0, BtoC: 0 };
+
+  const SerializerC = new Serializer<C>("c");
+
+  const BtoCRelator = new Relator<B, C>(async (data) => {
+   counters.BtoC++;
+   return { id: "1", prop: "c" };
+  }, SerializerC);
+
+  const SerializerB = new Serializer<B>("b", {
+   relators: { c: BtoCRelator },
+  });
+
+  const AtoBRelator = new Relator<A, B>(async (data) => {
+   counters.AtoB++;
+   return { id: "1", prop: "b" };
+  }, SerializerB);
+
+  const SerializerA = new Serializer<A>("a", {
+   relators: { b: AtoBRelator },
+  });
+
+  const serialized = await SerializerA.serialize({ id: "1", prop: "a" }, { depth: 2 });
+
+  console.log(
+   `A to B: ${counters.AtoB}\nB to C: ${counters.BtoC}\nSerialized Data:\n${inspect(
+    serialized,
+    false,
+    20
+   )}`
+  );
+  counters.AtoB = counters.BtoC = 0;
+ });
+});