Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tests that require libolm to be opted out of #729

Closed
kegsay opened this issue Jul 12, 2024 · 1 comment · Fixed by #738
Closed

Allow tests that require libolm to be opted out of #729

kegsay opened this issue Jul 12, 2024 · 1 comment · Fixed by #738
Assignees
@kegsay

Comments

@kegsay
Copy link
Member

kegsay commented Jul 12, 2024

So:

  • A) we don't need to force people to install libolm when they don't run crypto tests
  • B) we can import different versions of mautrix without causing version incompatibilities
@kegsay
Copy link
Member Author

kegsay commented Sep 24, 2024 •
edited
Loading

Given libolm is deprecated and we don't really have any tests which actually use it, and that we have complement-crypto for checking crypto, I'm inclined to remove the dep, to A) simplify the install process and B) not cause version conflicts - cc @sumnerevans

@kegsay kegsay self-assigned this Sep 24, 2024
kegsay added a commit that referenced this issue Sep 24, 2024
@kegsay
Remove libolm dependency
659596a 
See #729 for more information.

This is a breaking change because it removes blueprint functionality.
Specifically, it removes:
 - the field `OneTimeKeys` from the `User` struct.
 - the performance blueprint `BlueprintPerfE2EERoom`.
@kegsay kegsay mentioned this issue Sep 24, 2024
Merged
kegsay added a commit that referenced this issue Sep 25, 2024
@kegsay
Remove libolm dependency (#738)
9fb870e 
* Remove libolm dependency

See #729 for more information.

This is a breaking change because it removes blueprint functionality.
Specifically, it removes:
 - the field `OneTimeKeys` from the `User` struct.
 - the performance blueprint `BlueprintPerfE2EERoom`.

* Remove olm dep in client.go

* Fix device list test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kegsay kegsay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove libolm dependency matrix-org/complement
1 participant
@kegsay