Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt MSC2716 implementation to org.matrix.msc2716 experimental room version #176

Merged
merged 3 commits into from
Jul 26, 2021
Merged

Adapt MSC2716 implementation to org.matrix.msc2716 experimental room version #176

merged 3 commits into from
Jul 26, 2021

Conversation

MadLittleMods
Copy link
Contributor

Adapt MSC2716 implementation to org.matrix.msc2716 experimental room version

As introduced in matrix-org/synapse#10245

@MadLittleMods
Use experimental org.matrix.msc2716 room version for MSC2716 tests
556e1e9 
As introduced in matrix-org/synapse#10245,
use experimental `org.matrix.msc2716` room version.
kegsay
kegsay approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The duplication hurts. Consider making this a global:

var createRoomOpts = map[string]interface{}{
    "preset": "public_chat",
    "name": "the hangout spot",
    "room_version": "org.matrix.msc2716"
}

@MadLittleMods
Copy link
Contributor Author

The duplication hurts. Consider making this a global:

Updated 👍

@MadLittleMods MadLittleMods merged commit fd752eb into master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kegsay kegsay kegsay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MadLittleMods @kegsay