Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Localpart with LocalpartSuffix #674

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Replace Localpart with LocalpartSuffix #674

merged 2 commits into from
Oct 13, 2023

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Oct 13, 2023

Based on #673

This means clients can't register specific localparts, which is good for dirty runs.

TODO: Delete Deployment.Client and swap to Deployment.Register for standard alice/bob runs.

@kegsay kegsay requested review from a team as code owners October 13, 2023 15:58
DMRobertson
DMRobertson suggested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a prefix would be friendlier, but I have no other objections

Base automatically changed from kegan/register-and-login to main October 13, 2023 16:44
@kegsay
Replace Localpart with LocalpartSuffix
cb867e4 
This means clients can't register specific localparts, which is
good for dirty runs.
@kegsay
Fix bad refactor
b0ac7a0
@kegsay kegsay merged commit dd10fb0 into main Oct 13, 2023
3 of 4 checks passed
@kegsay kegsay deleted the kegan/localpart-suffix branch October 13, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kegsay @DMRobertson