Remove Deployment.Client and change Deploy #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `Deployment.Client` was used to get pre-registered clients. Now we want tests to register new users for each test, for dirty runs. So swap for `Deployment.Register` everywhere. - `Deploy` was used to deploy a blueprint. We don't want this to enable dirty runs. So replace it with the number of servers you need e.g `Deploy(t, 2)`.
sandhose
approved these changes
Oct 17, 2023
| CSAPIClients []*client.CSAPI | ||
| CSAPIClientsMutex sync.Mutex | ||
|
|
||
| // track all clients so if Restart() is called we can repoint to the new high-numbered port |
There was a problem hiding this comment.
I'm failing to understand this comment, but maybe I'll get it once I'm further in the review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployment.Clientwas used to get pre-registered clients. Now we want tests to register new users for each test, for dirty runs. So swap forDeployment.Registereverywhere.Deploywas used to deploy a blueprint. We don't want this to enable dirty runs. So replace it with the number of servers you need e.gDeploy(t, 2).