Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let appservice registration files contain arbitrary keys #682

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Oct 18, 2023

  • Remove storing/retrieving AS registrations from docker labels, there's no need for this.
  • Remove b.ApplicationService so arbitrary keys can be set on the registration file.

Fixes #680

Doesn't execute much more than this yet, so doesn't address #228 fully.

- Remove storing/retrieving AS registrations from docker labels, there's no need for this.
- Remove `b.ApplicationService` so arbitrary keys can be set on the registration file.
@kegsay kegsay requested review from a team as code owners October 18, 2023 14:52
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

internal/docker/deployment.go Outdated Show resolved Hide resolved
b/blueprints.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable application service registration files to be fully editable
2 participants