Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pseudoID compatibility to Invites #3126

Merged
merged 16 commits into from
Jul 6, 2023
Merged

Add pseudoID compatibility to Invites #3126

merged 16 commits into from
Jul 6, 2023

Conversation

devonh
Copy link
Collaborator

@devonh devonh commented Jun 28, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 32.40% and project coverage change: -0.02 ⚠️

Comparison is base (fea946d) 65.35% compared to head (d53e14a) 65.33%.

❗ Current head d53e14a differs from pull request most recent head dc1e64d. Consider uploading reports for the commit dc1e64d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3126      +/-   ##
==========================================
- Coverage   65.35%   65.33%   -0.02%     
==========================================
  Files         504      504              
  Lines       56056    56210     +154     
==========================================
+ Hits        36635    36725      +90     
- Misses      15600    15685      +85     
+ Partials     3821     3800      -21     
Flag Coverage Δ
unittests 49.78% <32.40%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
federationapi/api/api.go 100.00% <ø> (ø)
federationapi/internal/perform.go 37.47% <0.00%> (-2.45%) ⬇️
federationapi/routing/invite.go 35.16% <0.00%> (-10.69%) ⬇️
federationapi/routing/join.go 52.02% <ø> (ø)
roomserver/api/perform.go 100.00% <ø> (ø)
roomserver/internal/api.go 76.88% <0.00%> (ø)
roomserver/internal/perform/perform_join.go 71.47% <0.00%> (ø)
syncapi/notifier/notifier.go 78.10% <0.00%> (ø)
federationapi/routing/routing.go 66.60% <10.71%> (-3.30%) ⬇️
userapi/consumers/roomserver.go 67.78% <33.33%> (+0.70%) ⬆️
... and 4 more

... and 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devonh devonh marked this pull request as ready for review June 30, 2023 20:33
@devonh devonh requested a review from a team as a code owner June 30, 2023 20:33
@devonh
Copy link
Collaborator Author

devonh commented Jun 30, 2023

This should also fix #2751

federationapi/internal/perform.go Outdated Show resolved Hide resolved
federationapi/routing/invite.go Outdated Show resolved Hide resolved
clientapi/routing/membership.go Show resolved Hide resolved
@devonh devonh merged commit d507c5f into main Jul 6, 2023
15 of 16 checks passed
@devonh devonh deleted the invite branch July 6, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants