Disable character range check for user IDs #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check is not safe because Synapse hasn't enforced it properly either. Signed-off-by: Neil Alexander <git@neilalexander.dev>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
==========================================
+ Coverage 58.37% 58.47% +0.09%
==========================================
Files 51 51
Lines 7023 7032 +9
==========================================
+ Hits 4100 4112 +12
+ Misses 2533 2531 -2
+ Partials 390 389 -1
☔ View full report in Codecov by Sentry. |
kegsay
requested changes
Aug 15, 2023
There was a problem hiding this comment.
This is the hill I'm dying on.
matrix-org/matrix-spec#1506 (comment)
If the above clarification PR lands, then I'll admit defeat and merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check is not safe in existing room versions because Synapse hasn't enforced it properly either.
Related: matrix-org/matrix-spec#1506, matrix-org/matrix-spec-proposals#2828
Signed-off-by: Neil Alexander git@neilalexander.dev