Add new E2E error for expected UTD #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
requested changes
Mar 21, 2024
| @@ -39,16 +39,3 @@ enum class Domain { | |||
| enum class EventName { | |||
| Error | |||
| } | |||
|
|
|||
| enum class Name { | |||
There was a problem hiding this comment.
is this going to break any existing code?
There was a problem hiding this comment.
kotlin is not used, the apps are using kotlin2
There was a problem hiding this comment.
so can we get rid of kotlin altogether? Maybe a followup task.
There shouldn't. There are no TS types files kept in the git tree.
|
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
BillCarsonFr
requested review from
bmarty
and removed request for
t3chguy and
bmarty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new E2E error type for
Expected UTDAlso changed the json schema from
enumtooneOfin order to put some comments