Rename MXSessionSyncProgress #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/startup_stage
branch
from
337aa83
to
9a40692
Compare
Anderas
requested review from
a team and
alfogrillo
and removed request for
a team
Anderas
commented
Jan 18, 2023
|
|
||
| /// `MXSessionStartupProgress` tracks individual stages and per-stage progress | ||
| /// during a session startup, where the application may be blocking user interactions. | ||
| @objc public class MXSessionStartupProgress: NSObject { |
There was a problem hiding this comment.
No change of functionality from MXSessionSyncProgress, only renaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
MXSessionSyncProgresstoMXSessionStartupProgressas it more reflects its purpose. A future PR will be addingmigrationDatastage which does not really belong into the "sync" state but rather during "startup" stage where loading screen is shown to the user, before the session is ready / interactable.