Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jitsi pod to 7.0.1-lite #1754

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Upgrade to Jitsi pod to 7.0.1-lite #1754

merged 1 commit into from
Mar 30, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Mar 30, 2023

I picked the Lite version as it excludes a dependency on Giphy which appears to be a 22MB binary for iOS and I'm not sure we really need that.

Closes https://github.com/vector-im/customer-retainer/issues/28 although discussed with @benparsons that this on its own isn't enough to enable screensharing. Extra info should be in Jira.

(The Lite version excludes a dependency on Giphy).
@pixlwave pixlwave requested review from a team and alfogrillo and removed request for a team March 30, 2023 12:31
@pixlwave pixlwave marked this pull request as ready for review March 30, 2023 12:31
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a55ac46) 37.89% compared to head (f2b11a9) 37.89%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1754   +/-   ##
========================================
  Coverage    37.89%   37.89%           
========================================
  Files          616      616           
  Lines        97110    97110           
  Branches     41950    41950           
========================================
+ Hits         36797    36803    +6     
+ Misses       59266    59239   -27     
- Partials      1047     1068   +21     

see 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@alfogrillo alfogrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pixlwave pixlwave merged commit 19db8df into develop Mar 30, 2023
@pixlwave pixlwave deleted the doug/jitsi branch March 30, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants