Send extensible events structure and support on-demand parsing #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do this automatically to force a pool of messages in the wild we can use for testing.
This was referenced Jan 4, 2022
andybalaam
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Looks good, assuming we trust matrix-events-sdk. I had a look at https://github.com/matrix-org/matrix-events-sdk/blob/main/src/events/MessageEvent.ts#L113 and it looks like we will still emit something clients will understand...
|
Should we modify https://github.com/vector-im/element-web#setting-up-a-dev-environment to include this project? |
|
No, it actually makes development more hostile to have it linked up in the same way. Fixing that is somewhere on the list of things to do, as is making it possible for As for trust, I hope we trust it. I spent a lot of time making it have unit tests (for once) :P |
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Jan 31, 2022
* Support m.asset in m.location event content ([\matrix-org#2109](matrix-org#2109)). * Send extensible events structure and support on-demand parsing ([\matrix-org#2091](matrix-org#2091)). * Support cancelling events whilst they are in status = ENCRYPTING ([\matrix-org#2095](matrix-org#2095)). * Fix http-api butchering idServer requests ([\matrix-org#2134](matrix-org#2134)). Fixes element-hq/element-web#20680. * Don't remove streams that still have tracks ([\matrix-org#2104](matrix-org#2104)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires https://github.com/matrix-org/matrix-events-sdk
For matrix-org/matrix-react-sdk#7462
For element-hq/element-web#20405
MSC: matrix-org/matrix-spec-proposals#1767
This should be reviewable commit-by-commit.
Here's what your changelog entry will look like:
✨ Features