Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local volume control #2525

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Add local volume control #2525

merged 1 commit into from
Jul 25, 2022

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Jul 14, 2022 •
edited by github-actions bot
Loading

For element-hq/element-call#468

This change is marked as an internal change (Task), so will not be included in the changelog.

@SimonBrandner
Add local volume control
0d070e0 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner added the T-Task Tasks for the team like planning label Jul 14, 2022
@SimonBrandner SimonBrandner mentioned this pull request Jul 14, 2022
Merged
@SimonBrandner SimonBrandner marked this pull request as ready for review July 15, 2022 11:17
@SimonBrandner SimonBrandner requested a review from a team as a code owner July 15, 2022 11:17
@robintown
Copy link
Member

I'm trying to understand how this works - is localVolume or the event hooked up to anything?

@SimonBrandner
Copy link
Contributor Author

I'm trying to understand how this works - is localVolume or the event hooked up to anything?

Yes, it is in element-hq/element-call#468

@robintown
Copy link
Member

Oh, I see, volume has to be set on the media element in the front-end

@SimonBrandner
Copy link
Contributor Author

(going to block this until the element-call side is ready)

@SimonBrandner SimonBrandner mentioned this pull request Jul 16, 2022
Merged
@SimonBrandner
Copy link
Contributor Author

Unblocking and merging as the element-call side got product approval

@SimonBrandner SimonBrandner merged commit e876482 into robertlong/group-call Jul 25, 2022
@SimonBrandner SimonBrandner deleted the SimonBrandner/feat/local-volume branch July 25, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robintown robintown robintown approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonBrandner @robintown