Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always send back an httpStatus property if one is known #2753

Merged
merged 7 commits into from
Oct 14, 2022
Merged

Always send back an httpStatus property if one is known #2753

merged 7 commits into from
Oct 14, 2022

Commits on Oct 13, 2022

  1. Always send back an httpStatus property if one is known 

    Previously, non-JSON responses would be missing the `httpStatus`
property, which was different to how `request()` used to work.

Ensure we always send this property, even for non-JSON responses.
    @kegsay
    kegsay committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    5ed4e9f View commit details
    Browse the repository at this point in the history

  2. Fix broken tests

    @kegsay
    kegsay committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    400b457 View commit details
    Browse the repository at this point in the history

  3. err already sets httpStatus now

    @kegsay
    kegsay committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    e8be7af View commit details
    Browse the repository at this point in the history

  4. Linting

    @kegsay
    kegsay committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    ac561b7 View commit details
    Browse the repository at this point in the history

  5. Fix types on utils UTs

    @kegsay
    kegsay committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    ed78737 View commit details
    Browse the repository at this point in the history

  6. Additional tests for 'url' property to satisfy code coverage

    @kegsay
    kegsay committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    e32dfcc View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. More tests to satisfy sonarcloud

    @kegsay
    kegsay committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    500601e View commit details
    Browse the repository at this point in the history