Don't hang up calls that haven't started yet

[dbkr]

Checklist

• Tests written for new code (and old code if feasible)
• Linter and other CI checks pass
• Sign-off given on the changes (see CONTRIBUTING.md)

---

Here's what your changelog entry will look like:

🐛 Bug Fixes

• Don't hang up calls that haven't started yet (#2898).

[robintown]

I'd be interested to know how it's possible for disposeCall to get called before the call starts, just to make sure that this is the right place to fix this

[dbkr]

Sondarcloud seems to want me to refactor onCallFeedsChanged which hasn't changed in this PR...

[dbkr]

I strongly suspect it's if the call gets replaced before it's had a chance to send the invite

[t3chguy]

Sondarcloud seems to want me to refactor onCallFeedsChanged which hasn't changed in this PR...

Likely your base branch is out of date and thus re-introduces the issue

[robintown]

@dbkr Then would

matrix-js-sdk/src/webrtc/call.ts

Line 1082 in c389de9

if (this.state === CallState.WaitLocalMedia) return;

perhaps be a more appropriate place to put this? Otherwise the replaced call would never clean up its holds on the streams, I think

[dbkr]

Very good point - in fact that check should have included both the states in which we wouldn't have sent an invite anyway.