Prevent message edits in threads from getting (visually) lost #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justjanne
force-pushed
the
justjanne/fix/23916-editing-not-updating
branch
from
6dec366
to
d02b360
Compare
justjanne
force-pushed
the
justjanne/fix/23916-editing-not-updating
branch
from
d02b360
to
7780d27
Compare
- Separately handle new replies, local echos and old backlog events - This resolves the confusion between the handling old backlog events and new replies, which caused the bug
justjanne
force-pushed
the
justjanne/fix/23916-editing-not-updating
branch
from
7780d27
to
319554a
Compare
| if (event.threadRootId !== this.id) return; // ignore echoes for other timelines | ||
| if (this.lastEvent === event) return; | ||
| if (!event.isRelation(THREAD_RELATION_TYPE.name)) return; |
There was a problem hiding this comment.
I am struggling to see why this go removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Defect
Fixes: element-hq/element-web#23916
Here's what your changelog entry will look like:
🐛 Bug Fixes