Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element-R: Stub out isCrossSigningReady and isSecretStorageReady #3354

Merged
merged 6 commits into from
May 12, 2023
Merged

Element-R: Stub out isCrossSigningReady and isSecretStorageReady #3354

merged 6 commits into from
May 12, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented May 11, 2023 •
edited by github-actions bot
Loading

This is enough to get most of the cypress tests running, which is a win

This change is marked as an internal change (Task), so will not be included in the changelog.

@richvdh richvdh requested a review from a team as a code owner May 11, 2023 18:32
@richvdh richvdh added the T-Task Tasks for the team like planning label May 11, 2023
@richvdh
Copy link
Member Author

richvdh commented May 11, 2023

will add some tests to make this pass the quality gate

t3chguy
t3chguy approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sans sonar

@richvdh richvdh added this pull request to the merge queue May 12, 2023
Merged via the queue into develop with commit 63abd00 May 12, 2023
@richvdh richvdh deleted the rav/element-r/06_stub_out_device_checks branch May 12, 2023 12:35
@richvdh richvdh mentioned this pull request May 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from matrix-org/element-web-reviewers

@weeman1337 weeman1337 Awaiting requested review from weeman1337 weeman1337 is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richvdh @t3chguy