Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for stable MSC3882 get_login_token #3416

Merged
merged 8 commits into from
Sep 29, 2023
Merged

Support for stable MSC3882 get_login_token #3416

merged 8 commits into from
Sep 29, 2023

Conversation

hughns
Copy link
Member

@hughns hughns commented May 26, 2023 •
edited by github-actions bot
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

@hughns hughns mentioned this pull request May 31, 2023
Draft
4 tasks
@hughns hughns marked this pull request as ready for review September 27, 2023 08:59
@hughns hughns requested a review from a team as a code owner September 27, 2023 08:59
This was referenced Sep 27, 2023
Merged
Merged
richvdh
richvdh requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally seems good; a few nits

src/@types/auth.ts Outdated Show resolved Hide resolved
src/client.ts Outdated Show resolved Hide resolved
spec/integ/matrix-client-methods.spec.ts Outdated Show resolved Hide resolved
hughns and others added 2 commits September 27, 2023 17:20
@hughns @richvdh
Update src/@types/auth.ts
df2bd03 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@hughns @richvdh
Update spec/integ/matrix-client-methods.spec.ts
d4a1fc6 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@hughns hughns requested a review from richvdh September 27, 2023 16:27
richvdh
richvdh reviewed Sep 28, 2023
View reviewed changes
src/client.ts Outdated Show resolved Hide resolved
src/client.ts Outdated Show resolved Hide resolved
@hughns @richvdh
Update src/client.ts
d3b2999 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@hughns hughns requested a review from richvdh September 28, 2023 15:25
@hughns hughns added this pull request to the merge queue Sep 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 28, 2023
@andybalaam andybalaam added this pull request to the merge queue Sep 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 29, 2023
@andybalaam
Copy link
Contributor

I would force merge but there is another PR in the queue, so let's try updating the branch to my latest changes in the hope that they unflake it.

@andybalaam andybalaam added this pull request to the merge queue Sep 29, 2023
Merged via the queue into develop with commit f33da83 Sep 29, 2023
23 checks passed
@andybalaam andybalaam deleted the hughns/stable-msc3882 branch September 29, 2023 15:15
@matrixbot matrixbot mentioned this pull request Dec 21, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hughns @andybalaam @richvdh