Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate MatrixClient.{prepare,create}KeyBackupVersion in favour of new CryptoApi.resetKeyBackup API #3689

Merged
merged 4 commits into from
Sep 4, 2023
Merged

Deprecate MatrixClient.{prepare,create}KeyBackupVersion in favour of new CryptoApi.resetKeyBackup API #3689

merged 4 commits into from
Sep 4, 2023

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Sep 1, 2023 •
edited by github-actions bot
Loading

Deprecates prepareKeyBackupVersion/createKeyBackupVersion in favor of a new api resetKeyBackup that deletes existing backups if needed and then creates a new one.

Rust Implemention is just stub for now.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🦖 Deprecations

  • Deprecate MatrixClient.{prepare,create}KeyBackupVersion in favour of new CryptoApi.resetKeyBackup API (#3689).

@BillCarsonFr BillCarsonFr added the T-Task Tasks for the team like planning label Sep 1, 2023
@BillCarsonFr BillCarsonFr mentioned this pull request Sep 1, 2023
Merged
3 tasks
@BillCarsonFr BillCarsonFr marked this pull request as ready for review September 1, 2023 15:28
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner September 1, 2023 15:28
@BillCarsonFr BillCarsonFr requested review from t3chguy, kerryarchibald and richvdh and removed request for kerryarchibald and t3chguy September 1, 2023 15:28
@BillCarsonFr BillCarsonFr mentioned this pull request Sep 1, 2023
Closed
3 tasks
@richvdh richvdh changed the title new resetKeyBackup API Add new CryptoApi.resetKeyBackup API Sep 1, 2023
@richvdh richvdh added T-Deprecation A pull request that makes something deprecated and removed T-Task Tasks for the team like planning labels Sep 1, 2023
@richvdh richvdh changed the title Add new CryptoApi.resetKeyBackup API Deprecate MatrixClient.{prepare,create}KeyBackupVersion in favour of new CryptoApi.resetKeyBackup API Sep 1, 2023
richvdh
richvdh requested changes Sep 1, 2023
View reviewed changes
src/crypto-api.ts Outdated Show resolved Hide resolved
src/rust-crypto/rust-crypto.ts Outdated Show resolved Hide resolved
src/crypto-api.ts Outdated Show resolved Hide resolved
src/client.ts Show resolved Hide resolved
spec/integ/crypto/crypto.spec.ts Show resolved Hide resolved
spec/integ/crypto/crypto.spec.ts Show resolved Hide resolved
spec/integ/crypto/crypto.spec.ts Outdated Show resolved Hide resolved
spec/integ/crypto/crypto.spec.ts Outdated Show resolved Hide resolved
spec/integ/crypto/crypto.spec.ts Outdated Show resolved Hide resolved
spec/integ/crypto/crypto.spec.ts Outdated Show resolved Hide resolved
richvdh
richvdh reviewed Sep 4, 2023
View reviewed changes
spec/integ/crypto/crypto.spec.ts Outdated Show resolved Hide resolved
spec/integ/crypto/crypto.spec.ts Show resolved Hide resolved
richvdh
richvdh requested changes Sep 4, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do move the resetKeyBackup test outside the bosstrapSecretStorage block.

Otherwise, just a few nits.

spec/integ/crypto/crypto.spec.ts Outdated Show resolved Hide resolved
spec/integ/crypto/crypto.spec.ts Outdated Show resolved Hide resolved
@richvdh richvdh self-requested a review September 4, 2023 15:15
@richvdh richvdh added this pull request to the merge queue Sep 4, 2023
@richvdh richvdh removed this pull request from the merge queue due to a manual request Sep 4, 2023
@richvdh richvdh added this pull request to the merge queue Sep 4, 2023
Merged via the queue into develop with commit c65e329 Sep 4, 2023
21 checks passed
@richvdh richvdh deleted the valere/element-r/keybackup_reset_api branch September 4, 2023 20:13
@github-actions github-actions bot mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
T-Deprecation A pull request that makes something deprecated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillCarsonFr @richvdh