Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export base64 utils #3820

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Export base64 utils #3820

merged 1 commit into from
Oct 20, 2023

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Oct 20, 2023

We use these from react-sdk (from crypto, when they were there, but I just moved them and inadvertantly broke react-sdk).

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

We use these from react-sdk (from crypto, when they were there,
but I just moved them and inadvertantly broke react-sdk).
@dbkr dbkr added the T-Task Tasks for the team like planning label Oct 20, 2023
@dbkr dbkr requested a review from a team as a code owner October 20, 2023 16:48
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this pull request Oct 20, 2023
Apologies, I broke this with matrix-org/matrix-js-sdk#3818

This fixes it, but needs matrix-org/matrix-js-sdk#3820
@dbkr dbkr added this pull request to the merge queue Oct 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 20, 2023
@dbkr dbkr merged commit 6359e10 into develop Oct 20, 2023
26 checks passed
@dbkr dbkr deleted the dbkr/export_base64 branch October 20, 2023 17:18
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants