crypto: configure key sharing strategy based on DeviceIsolationMode #4425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
force-pushed
the
valere/invisible_crypto_decryption_flag
branch
from
522b369
to
2be0544
Compare
4 tasks
|
Will need to be updated in light of #4428 |
BillCarsonFr
force-pushed
the
valere/invisible_crypto_decryption_flag
branch
from
2be0544
to
4050919
Compare
BillCarsonFr
force-pushed
the
valere/invisible_crypto_decryption_flag
branch
from
4050919
to
5e43195
Compare
BillCarsonFr
changed the title
fix eslint import error cryptoMode was renamed to deviceIsolationMode post rebase fix: Device Isolation mode name changes
BillCarsonFr
force-pushed
the
valere/invisible_crypto_decryption_flag
branch
from
5e43195
to
87f5304
Compare
Done |
richvdh
reviewed
Sep 30, 2024
src/rust-crypto/RoomEncryptor.ts
Outdated
| public async prepareForEncryption(globalBlacklistUnverifiedDevices: boolean): Promise<void> { | ||
| public async prepareForEncryption( | ||
| globalBlacklistUnverifiedDevices: boolean, | ||
| deviceIsolationMode: DeviceIsolationMode = new AllDevicesIsolationMode(false), |
There was a problem hiding this comment.
given that this is only called in one place (except in tests), we should not provide a default value.
Likewise below.
richvdh
approved these changes
Sep 30, 2024
|
LGTM otherwise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#28038
based on the work done on #4407
Checklist
public/exportedsymbols have accurate TSDoc documentation.