Prepare delayed call leave events more reliably #4447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Try sending call join after preparing delayed leave - On leave, send delayed leave instead of a new event
AndrewFerr
commented
Oct 10, 2024
| ); | ||
| } catch (e) { | ||
| // TODO: Retry if rate-limited | ||
| if ((<MatrixError>e).errcode === "M_NOT_FOUND") { |
There was a problem hiding this comment.
This doesn't work in embedded mode! The widget API apparently doesn't preserve the errcode or HTTP response code...
There was a problem hiding this comment.
Might be worth a comment in-code then
robintown
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Ferrazzutti andrewf@element.io
Checklist
public/exportedsymbols have accurate TSDoc documentation.