fix typo where headers was not being used and thus sent wrong content-type
#643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
changed the title
headers was not being used and thus sent wrong mimeheaders was not being used and thus sent wrong content-type
ara4n
reviewed
Jun 8, 2018
|
It'd only break things if the server was expecting JSON with a content-type of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
higher up this method copies
opts.headersintoheadersand ifjson && datathen sets the content-type toapplication/jsonWhilst writing matrix-search I was left with js-sdk reaching out to the express server with some json payload but plain text content type
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com