Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status/presence list support #135

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add status/presence list support #135

wants to merge 3 commits into from

Conversation

jfrederickson
Copy link
Contributor

@jfrederickson jfrederickson commented May 22, 2017 •
edited
Loading

@matrixbot
Copy link
Member

Can one of the admins verify this patch?

@jfrederickson jfrederickson mentioned this pull request May 23, 2017
Closed
@non-Jedi
Copy link
Collaborator

This looks great. Thanks @jfrederickson. I'll need to check that it actually matches the spec and then hand-test it, which I'll hopefully get to soon. In the meantime, would you mind signing off on this per the project's CONTRIBUTING.rst?

@non-Jedi non-Jedi self-requested a review September 22, 2017 16:23
@jfrederickson
Copy link
Contributor Author

Ah right - since I've already opened the PR and CONTRIBUTING.rst says I can put it in a PR comment...

Signed-off-by: Jonathan Frederickson <jonathan@terracrypt.net>

It's worth noting that Synapse is (was?) a bit finicky re: its status message handling. The last time I tried it, my status message was overwritten the next time my presence was updated, even if the new presence didn't contain a status message. (matrix-org/synapse#2245) But doesn't mean we can't support it client-side. 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@non-Jedi non-Jedi Awaiting requested review from non-Jedi

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfrederickson @matrixbot @non-Jedi