Add prettier #18
Add prettier #18
Conversation
There was a problem hiding this comment.
Thank you for your contribution @dhenneke . Changes do basically look good 👍 Only some smaller notes.
|
I am trying to figure out what to do about Node 14: https://matrix.to/#/!bEWtlqtDwCLFIAKAcv:matrix.org/$5Xdul9sib5y7FWTxJXoQhQ3wWt9YMiscF56oOGjnzYk?via=matrix.org&via=element.io&via=envs.net |
|
I added |
Yep. It is a peer dependency of eslint-plugin-matrix-org . Depending on the configuration it has to be installed. |
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
dhenneke
force-pushed
the
nic/feat/prettier
branch
from
cff62e6
to
de780c0
Compare
|
I rebased the branch (the formatting changes made it hard to update it) and also upgraded the pipeline to use matrix builds for node 18 & latest. If you prefer, I can also move the pipeline part to a separate PR. |
|
The workflows are still failing. @dhenneke can you use the same as in https://github.com/matrix-org/matrix-react-sdk/blob/develop/.github/workflows/static_analysis.yaml#L70 etc.? |
|
Yes I will update the actions later 👍 |
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
package.json
Outdated
| "build:compile": "babel -d lib --verbose --extensions \".ts,.tsx\" src", | ||
| "start": "tsc -p ./tsconfig.build.json -w", | ||
| "test": "jest", | ||
| "lint": "eslint src test && tsc --noEmit && prettier --check", |
There was a problem hiding this comment.
Prettier needs a argument what to check:
| "lint": "eslint src test && tsc --noEmit && prettier --check", | |
| "lint": "eslint src test && tsc --noEmit && prettier --check .", |
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
|
@weeman1337 will you merge this? |
I've just learned, that „You’re not authorized to merge this pull request.“ @richvdh can you merge it? |
This PR aligns the code formatting to the other projects to make it easier to work with the code.