Set up CI to lint workflows with action-validator #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
approved these changes
Nov 24, 2023
| @@ -9,44 +9,60 @@ jobs: | |||
| # ================================================ | |||
|
|
|||
| eslint: | |||
| name: "ESLint (Node ${{ matrix.node }})" | |||
| name: "ESLint (Node ${{ matrix.node == '*' && 'latest' || matrix.node }})" | |||
There was a problem hiding this comment.
"*" is not the same as latest, as I understand it. (If it was, we wouldn't need to change this.) IMHO * here would be better here: whilst not terribly clear for those who don't know what it means, it is at least not actively misleading.
| "lint": "eslint src test && tsc --noEmit && prettier --check .", | ||
| "lint:fix": "prettier --write . && eslint --fix src test", | ||
| "lint": "yarn lint:js && yarn lint:workflows", | ||
| "lint:js": "eslint src test && tsc --noEmit && prettier --check .", |
There was a problem hiding this comment.
not loving that we have a lint:js that does something different to the lint:js in element-web (notably: it runs tsc), but I also don't feel very strongly about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the equivalent of element-hq/element-web#26621 applied to this repository.