Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
Use LTS nodejs in github workflows (#12726)
Browse files Browse the repository at this point in the history
Currently our GH workflows all use nodejs 18, but that's not compatible with the
stated support range of matrix-js-sdk, which requires the latest LTS nodejs;
so, when we attermpt to `yarn install` on an older nodejs, we get an error.

Switch to LTS nodejs for all the places we set up nodejs.
  • Loading branch information
richvdh authored Jul 4, 2024
1 parent e75dc4e commit 1fbc972
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/end-to-end-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ jobs:
- uses: actions/setup-node@v4
with:
cache: "yarn"
node-version: "lts/*"

- name: Fetch layered build
id: layered_build
Expand Down Expand Up @@ -121,6 +122,7 @@ jobs:
with:
cache: "yarn"
cache-dependency-path: matrix-react-sdk/yarn.lock
node-version: "lts/*"

- name: Install dependencies
working-directory: matrix-react-sdk
Expand Down Expand Up @@ -172,6 +174,7 @@ jobs:
if: inputs.skip != true
with:
cache: "yarn"
node-version: "lts/*"

- name: Install dependencies
if: inputs.skip != true
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/static_analysis.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
- uses: actions/setup-node@v4
with:
cache: "yarn"
node-version: "lts/*"

- name: Install Deps
run: "./scripts/ci/install-deps.sh"
Expand Down Expand Up @@ -83,6 +84,7 @@ jobs:
- uses: actions/setup-node@v4
with:
cache: "yarn"
node-version: "lts/*"

# Does not need branch matching as only analyses this layer
- name: Install Deps
Expand All @@ -100,6 +102,7 @@ jobs:
- uses: actions/setup-node@v4
with:
cache: "yarn"
node-version: "lts/*"

# Does not need branch matching as only analyses this layer
- name: Install Deps
Expand All @@ -117,6 +120,7 @@ jobs:
- uses: actions/setup-node@v4
with:
cache: "yarn"
node-version: "lts/*"

# Does not need branch matching as only analyses this layer
- name: Install Deps
Expand All @@ -134,6 +138,7 @@ jobs:
- uses: actions/setup-node@v4
with:
cache: "yarn"
node-version: "lts/*"

- name: Install Deps
run: "scripts/ci/layered.sh"
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ jobs:
- name: Yarn cache
uses: actions/setup-node@v4
with:
node-version: "lts/*"
cache: "yarn"

- name: Install Deps
Expand Down Expand Up @@ -115,6 +116,7 @@ jobs:
- uses: actions/setup-node@v4
with:
cache: "yarn"
node-version: "lts/*"

- name: Run tests
run: "./scripts/ci/app-tests.sh"
Expand Down

0 comments on commit 1fbc972

Please sign in to comment.