Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
Fix freeze/crash when 1:1 calling (#8057) (#8058)
Browse files Browse the repository at this point in the history
* Fix freeze/crash when 1:1 calling

Don't log call feed objects because they reference the client and
it causes the client to get logged too.

* Log purpose too
  • Loading branch information
dbkr authored Mar 15, 2022
1 parent e485907 commit 4d6643c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 4 additions & 1 deletion src/components/views/voip/AudioFeed.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,10 @@ export default class AudioFeed extends React.Component<IProps, IState> {
// load() explicitly, it shouldn't be a problem. - Dave
await element.load();
} catch (e) {
logger.info("Failed to play media element with feed", this.props.feed, e);
logger.info(
`Failed to play media element with feed for userId ` +
`${this.props.feed.userId} with purpose ${this.props.feed.purpose}`, e,
);
}
}

Expand Down
5 changes: 4 additions & 1 deletion src/components/views/voip/VideoFeed.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,10 @@ export default class VideoFeed extends React.PureComponent<IProps, IState> {
// load() explicitly, it shouldn't be a problem. - Dave
await element.play();
} catch (e) {
logger.info("Failed to play media element with feed", this.props.feed, e);
logger.info(
`Failed to play media element with feed for userId ` +
`${this.props.feed.userId} with purpose ${this.props.feed.purpose}`, e,
);
}
}

Expand Down

0 comments on commit 4d6643c

Please sign in to comment.