Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
Remove variation selectors from quick reactions
Browse files Browse the repository at this point in the history
This fixes a regression introduced by the full emoji picker which inserted empty
variation selectors in the thumbs up / down quick reactions. Since this makes
them different characters, it would cause us to not aggregate thumbs from web
vs. mobile together.

Regressed by #3554
Fixes element-hq/element-web#11335
  • Loading branch information
jryans committed Nov 7, 2019
1 parent 54cea6a commit 91f3b75
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/components/views/emojipicker/QuickReactions.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import EMOJIBASE from 'emojibase-data/en/compact.json';
import sdk from '../../../index';
import { _t } from '../../../languageHandler';

const QUICK_REACTIONS = ["πŸ‘οΈ", "πŸ‘ŽοΈ", "πŸ˜„", "πŸŽ‰", "πŸ˜•", "❀️", "πŸš€", "πŸ‘€"];
const QUICK_REACTIONS = ["πŸ‘", "πŸ‘Ž", "πŸ˜„", "πŸŽ‰", "πŸ˜•", "❀️", "πŸš€", "πŸ‘€"];
EMOJIBASE.forEach(emoji => {
const index = QUICK_REACTIONS.indexOf(emoji.unicode);
if (index !== -1) {
Expand Down

0 comments on commit 91f3b75

Please sign in to comment.