This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
New toast design #10258
Closed
New toast design #10258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weeman1337
added
T-Enhancement
weeman1337
force-pushed
the
weeman1337/new-toast-design
branch
from
36273d4
to
4f6bc2f
Compare
weeman1337
force-pushed
the
weeman1337/new-toast-design
branch
from
4f6bc2f
to
13e9b2c
Compare
|
Percy doesn't seem to take a screenshot of a toast yet. |
kerryarchibald
approved these changes
Mar 2, 2023
| .mx_Toast_title { | ||
| display: flex; | ||
| align-items: center; | ||
| column-gap: 8px; | ||
| width: 100%; | ||
| box-sizing: border-box; | ||
| margin-bottom: $spacing-16; | ||
|
|
||
| h2 { |
There was a problem hiding this comment.
Could use the styled Heading component instead of the h2 tag and remove most of this style
There was a problem hiding this comment.
Except this style matches our h3 styling, which might cause a bit more fallout with changed snapshots etc
There was a problem hiding this comment.
The mx_Toast_title_countIndicator below also could be replaced with a Caption component
|
This PR is put on hold. Need to clarify the scope. |
|
This PR will be replaced by a new one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes element-hq/element-web#24490
Designs: element-hq/element-web#24490 (comment)
ℹ️ in design the toast is more on the left side.
I did not do this, because many of our Cypress tests would explode, because they currently don't care about the toasts.
Checklist
Here's what your changelog entry will look like:
✨ Features