Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Remove obsolete CSS declarations from _RoomHeader.pcss #10496

Merged
merged 5 commits into from
Apr 20, 2023
Merged

Remove obsolete CSS declarations from _RoomHeader.pcss #10496

merged 5 commits into from
Apr 20, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 3, 2023 •
edited by github-actions bot
Loading

This PR removes obsolete CSS declarations from _RoomHeader.pcss.

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@luixxiul
Remove obsolete mx_RoomHeader_textButton and mx_RoomHeader_cancelButton
9388afa 
These declarations have been obsolete since GroupView.js was deleted by fce36ec.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul
Remove obsolete mx_RoomHeader_spinner
e020e29 
As of 79d3cca it was used as follows:

````
if (this.props.saving) {
    const Spinner = sdk.getComponent("elements.Spinner");
    spinner = <div className="mx_RoomHeader_spinner"><Spinner /></div>;
}
````

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul
Remove obsolete mx_RoomHeader_info
6502f63 
This was deprecated by 18fedb2

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 3, 2023
@luixxiul luixxiul marked this pull request as ready for review April 20, 2023 07:02
@luixxiul luixxiul requested a review from a team as a code owner April 20, 2023 07:02
t3chguy
t3chguy approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@t3chguy t3chguy enabled auto-merge April 20, 2023 08:06
@t3chguy t3chguy added this pull request to the merge queue Apr 20, 2023
Merged via the queue into matrix-org:develop with commit 8867f18 Apr 20, 2023
@luixxiul luixxiul mentioned this pull request Apr 30, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@alunturner alunturner Awaiting requested review from alunturner alunturner is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luixxiul @t3chguy