Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Cypress test: can't switch back to default homeserver #11130

Merged
merged 5 commits into from
Jun 27, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Jun 22, 2023

element-hq/element-web#25650

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jun 22, 2023
@kerryarchibald kerryarchibald marked this pull request as ready for review June 23, 2023 04:38
@kerryarchibald kerryarchibald requested a review from a team as a code owner June 23, 2023 04:38

cy.findByRole("button", { name: "Edit" }).click();

// select the default server again
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be great if the comment could be clear that this is here as a regression test, otherwise it just looks like an unnecessary extra step in the context of the the test name

@robintown robintown removed the request for review from justjanne June 26, 2023 18:04
@kerryarchibald kerryarchibald added this pull request to the merge queue Jun 27, 2023
Merged via the queue into develop with commit 9704c9f Jun 27, 2023
@kerryarchibald kerryarchibald deleted the kerry/25650/server-picker-cypress branch June 27, 2023 22:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants