Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Disable flaky cypress test #11993

Closed
wants to merge 2 commits into from

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Dec 4, 2023

As per element-hq/element-web#26679

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@dbkr dbkr added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Dec 4, 2023
@dbkr dbkr requested a review from a team as a code owner December 4, 2023 12:14
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that the affected test runs include the previous fix to this issue (#11981)?

Also please could you update the issue to include info on how it is failing, with some links to GHA logs?

@dbkr
Copy link
Member Author

dbkr commented Dec 4, 2023

Have added the info to the old issue, reopened it, closed the new one and repointed this PR at the old issue. Unfortunately it appears there have been two failures today with the fix (there were some where it didn't have the fix too).

@dbkr dbkr requested a review from richvdh December 4, 2023 15:56
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@dbkr
Copy link
Member Author

dbkr commented Dec 7, 2023

This is conflicted now and the test doesn't seem to be flaking anymore, so I'm going to close this. It's here if we need it.

@dbkr dbkr closed this Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants