This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Playwright: Enable & fix skipped tests in new-messages.spec.ts
#12013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
added
the
T-Task
This was referenced Dec 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Part of element-hq/element-web#25449
Closes element-hq/element-web#26679 element-hq/element-web#26676
Me sending a message from a different client marks room as readbecause as the comment explains, the test is bad written. Instead of keeping a skipped incorrect test, I choose to delete itReading a thread root within the thread view marks it as read in the main timeline, the current behavior in the test is to displayed the thread root at the middle of the timeline when we want to open it. So I updated the test to match this behavior. (We want to test unread, not the thread position when opened)This change is marked as an internal change (Task), so will not be included in the changelog.