Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Collect decryption failure translations together #12436

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Apr 17, 2024

They are not specific to threads.

They are not specific to threads.
@richvdh richvdh requested a review from a team as a code owner April 17, 2024 12:48
@richvdh richvdh added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 17, 2024
@t3chguy
Copy link
Member

t3chguy commented Apr 17, 2024

This won't work, as only the source i18n file is pushed to Weblate, the rest are only pulled. So your changes in non-en files will be reverted next pull

@richvdh
Copy link
Member Author

richvdh commented Apr 17, 2024

Please can you give me some pointers as to what I should be doing then?

@t3chguy
Copy link
Member

t3chguy commented Apr 17, 2024

Only changing the en file, the rest of the updates would need to be done via Localazy which owns those files.

@richvdh
Copy link
Member Author

richvdh commented Apr 17, 2024

I thought I asked you about this and you told me I had to change it. And I spent two hours writing a script to do so 😠

@richvdh
Copy link
Member Author

richvdh commented Apr 17, 2024

Only changing the en file

Done.

@t3chguy
Copy link
Member

t3chguy commented Apr 17, 2024

I thought I asked you about this and you told me I had to change it. And I spent two hours writing a script to do so 😠

All I recall is you asking if we had such a script and I answered you that we did: https://github.com/matrix-org/matrix-web-i18n/blob/main/scripts/rekey.ts

@richvdh richvdh added this pull request to the merge queue Apr 18, 2024
Merged via the queue into develop with commit d402b52 Apr 18, 2024
22 checks passed
@richvdh richvdh deleted the rav/historical_events/03_collect_utd_messages branch April 18, 2024 11:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants