Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Revert "MSC3575 (Sliding Sync) add well-known proxy support" #12491

Closed
wants to merge 1 commit into from

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented May 2, 2024

@richvdh richvdh requested a review from a team as a code owner May 2, 2024 17:44
@richvdh richvdh added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label May 2, 2024
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix it instead of reverting it, develop isn't guaranteed to be stable. It should be a case of using an OPTIONS request instead.

@richvdh
Copy link
Member Author

richvdh commented May 2, 2024

Well, I feel quite strongly we should fix this somehow as soon as possible, because the longer it is up, the more people on develop are going to have completely broken sessions because the sliding sync is polling for them.

I'd also like to see this be tested better rather than continuing to iterate given how badly it broke things.

Anyway, this is my best effort this evening. Please either merge it, or make a better solution yourself.

@turt2live
Copy link
Member

I've done the more surgical approach here: #12492

@richvdh richvdh closed this May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
3 participants