Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Migrate TooltipTarget usage to compound Tooltip #12542

Merged
merged 9 commits into from
May 22, 2024

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented May 16, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Part of element-hq/element-web#26762

Replace the usage of TooltipTarget by the compound tooltip.

The tooltip location sharing has its position changed. The new tooltip doesn't have an option to display it in a "inner" way. For the sake to use one tooltip across all element, I think that this change reasonable.

@florianduros florianduros added this pull request to the merge queue May 22, 2024
Merged via the queue into develop with commit 1190de9 May 22, 2024
38 of 42 checks passed
@florianduros florianduros deleted the florianduros/tooltip/tooltip-target branch May 22, 2024 12:39
thoraj added a commit to verji/matrix-react-sdk that referenced this pull request Aug 15, 2024
* Upgrade dependency to matrix-js-sdk@32.3.0-rc.0

* v3.100.0-rc.0

* Upgrade dependency to matrix-js-sdk@32.3.0

* Remove code smell assertion identified by Sonar (matrix-org#12547)

* This assertion is unnecessary since the receiver accepts the original type of the expression

* Implement `client.getDomain()` null check

* Update comment since `AutoDiscovery.findClientConfig` may still throw

* Report verification and recovery state to posthog (matrix-org#12516)

* Report verification and recovery state to posthog

* Fix CryptoApi import

* Fix js-sdk import

* Review: Use DeviceVerificationStatus instead of CrossSigningStatus

* Review: Clean condition to check secrets in 4S

* review: Fix redundent !!

* Deprecate `Tooltip.tsx`

* Use tooltip compound in `MessageComposer.tsx`

* Use tooltip compound in `ReadReceiptGroup` component

* Use tooltip compound in `ReadReceiptPerson` component

* Delete `useTooltip.tsx`

* Use compound tooltip in `ReactionRowButton`

* Upgrade dependency to matrix-js-sdk@32.4.0

* Migrate `TooltipTarget` usage to compound `Tooltip` (matrix-org#12542)

* Use new tooltip in `RoomTopic.tsx`

* Use new tooltip in `MLocationBody.tsx`

* Fix room topic

* Update location snapshot

* Use new tooltip in `AppPermission.tsx`

* Remove `TooltipTarget`

* Add tests for `RoomTopic`

* Add tests for `ReadReceiptGroup.tsx`

* Add more tests for `ReadReceiptGroup.tsx`

* Add more test for `ReactionsRowButton.tsx`

* Add seedrandom dep to `resolutions` (matrix-org#12552)

* Move seedrandom dep to `resolutions`

... to shut renovate up

* Reinstate `seedrandom` as dev dependency

If we just declare it in `resolutions`, it doesn't get installed at all,
because it is only a devDependency of `bloom-filters`.

* [create-pull-request] automated change (matrix-org#12554)

Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com>

* Avoid using deprecated exports, fields, and duplicate code (matrix-org#12555)

* Fix tabbedview breakpoint width (matrix-org#12556)

Which should be 1024 according to the designs, not 768

* Tooltip: close field tooltip when ESC is pressed (matrix-org#12553)

* Close field tooltip when ESC is pressed

* Use `Key.ESCAPE`

* Close the release announcement when a dialog is opened (matrix-org#12559)

* Fire `ModalManagerEvent.Closed` when a dialog is closed

* Listen to modal events in the RA

* Fix first RA test

* Upgrade dependency to matrix-js-sdk@33.0.0-rc.0

* v3.100.0-rc.1

* Upgrade dependency to matrix-js-sdk@33.0.0

* v3.100.0

---------

Co-authored-by: RiotRobot <releases@riot.im>
Co-authored-by: Ed Geraghty <edg@privacyinternational.org>
Co-authored-by: Valere <valeref@matrix.org>
Co-authored-by: Florian Duros <florian.duros@ormaz.fr>
Co-authored-by: Florian Duros <florianduros@element.io>
Co-authored-by: David Baker <dbkr@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants