Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Message Pinning: rework the message pinning list in the right panel #12825

Merged
merged 16 commits into from
Aug 16, 2024

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Jul 25, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Figma: https://www.figma.com/design/nwbnk8RaZctjrrRGTUcx1X/Pinned-Messages?node-id=38-163717&t=QpPa8ByPpyclY6Wq-0
Part of https://github.com/element-hq/element-internal/issues/600 & https://github.com/element-hq/element-internal/issues/608

The PR can be reviewed commit by commit.
The content is the rework of the message pinning list in the right panel:

  • Rewrited completely the PinnedEventTile to match figma design and behavior
  • Refactored and documented PinnedMessagesCard
  • Extracted the logic of the message pinning list inside PinnedMessages
  • Rework existing tests and improved the code coverage
  • Added e2e tests

@florianduros florianduros added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jul 25, 2024
res/css/views/rooms/_PinnedEventTile.pcss Outdated Show resolved Hide resolved
res/css/views/rooms/_PinnedEventTile.pcss Outdated Show resolved Hide resolved
src/i18n/strings/en_EN.json Outdated Show resolved Hide resolved
src/components/views/dialogs/UnpinAllDialog.tsx Outdated Show resolved Hide resolved
src/components/views/rooms/PinnedEventTile.tsx Outdated Show resolved Hide resolved
@florianduros florianduros force-pushed the florianduros/pinned-messages/list branch from 68b52ed to 02cea96 Compare August 14, 2024 15:45
@t3chguy
Copy link
Member

t3chguy commented Aug 14, 2024

In future please avoid force pushing after a review was made as now I can't just review the diff since my last review

@florianduros
Copy link
Contributor Author

@t3chguy Raaah I used git absorb to make the history cleaner, will do it after the review

@florianduros florianduros added this pull request to the merge queue Aug 16, 2024
Merged via the queue into develop with commit 6f3dc30 Aug 16, 2024
29 checks passed
@florianduros florianduros deleted the florianduros/pinned-messages/list branch August 16, 2024 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants