This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Support pagination while querying for issues in flaky reporter #12832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we collect all the issues that were created after Jan 1 2024
MidhunSureshR
added
the
T-Task
t3chguy
reviewed
Jul 26, 2024
Comment on lines
+111
to
+112
| const headers = { Authorization: `Bearer ${GITHUB_TOKEN}` }; | ||
| const body = `${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}`; |
There was a problem hiding this comment.
why did this move into the for loop? tiny de-optimisation
There was a problem hiding this comment.
didn't think much of it, just moved the variables closer to where they're used. I'm sure the compiler will move stuff out for us anyway 🤞
MidhunSureshR
commented
Jul 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.