This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Remove unused CryptoCallbacks implementations #12919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
added
the
T-Task
This thing is unused with the rust crypto stack (which is lucky, because it uses methods that only work with the legacy stack).
This callback is no longer used, so there is no need for an implementation.
This is no longer written to, so is redundant.
richvdh
force-pushed
the
rav/element-r/remove_old_crypto_callbacks
branch
from
d7ca383
to
e1f4c00
Compare
As before: this hook is no longer used by the js-sdk, so writing to it is pointless.
richvdh
force-pushed
the
rav/element-r/remove_old_crypto_callbacks
branch
from
e1f4c00
to
8d6bc3c
Compare
richvdh
added a commit
to matrix-org/matrix-react-sdk-module-api
that referenced
this pull request
Aug 27, 2024
) As of matrix-org/matrix-react-sdk#12919, getDehydrationKeyCallback is unused
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per matrix-org/matrix-js-sdk#4376,
CryptoCallbacks.onSecretRequestedandCryptoCallbacks.getDehydrationKeyare no longer used. We may as well remove the code that writes to them.Suggest review commit-by-commit