This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix having to decrypt & download in two steps #4162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
approved these changes
Mar 3, 2020
|
@jryans any chance you could test in Safari 👼 |
Yes! It triggers a per-site permission prompt the first time. If you agree, download proceeds from first click as desired. |
|
@jryans dear dev, I must kindly point out that not all the browsers are support the "allow-downloads-without-user-activation" flag, for example in Chrome(my Chrome version is 106.0.5249.119 Windows x64). There will be an error in the Chrome console and the download button doesn't work at all.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#9035
This may not work in all browser configurations until
allow-downloads-without-user-activationis everywhere which is why the button remains "Decrypt". Nad OK'd this. element-hq/element-web#7431 tracks further UX improvements.Tested in: