This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Display started polls in timeline (without votes) (behind labs setting) #7088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
added
the
T-Enhancement
andybalaam
added
T-Task
germain-gg
approved these changes
Nov 5, 2021
gaelledel
suggested changes
Nov 9, 2021
There was a problem hiding this comment.
- The hover state should show background colour for option frames
Current:
Desired
- The poll creator name and avatar should be the same size and layout, colour as a normal text message.
Current:
Desired:
- Also it seems to take a long time for the poll to be rendered on the timeline when I press Create poll from the modal. Unsure what can be done on this one.
I tried it just now and it was instant, so I think the delay you saw was probably not related to the work we are doing here. |
gaelledel
approved these changes
Nov 10, 2021
|
@gaelledel do you mean the circular border of the radio buttons? Should that be quinary? In #7087 I made it quaternary - was that incorrect? |
|
No I meant the rectangular border of options on the timeline |
Cool, yes these are quinary. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't work yet, but this shows polls in the timeline, and allows you to click options to see how they look.
Posting this PR in the hope of getting early feedback on the visual design and code structure.
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://618bac011943fa006f02f0e2--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.