This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Move all polls processing to events-sdk & prep for stable polls #7517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
added
the
T-Task
This was referenced Jan 12, 2022
turt2live
changed the title
This makes polls support the full range of extensible events (both parsing and generation).
turt2live
force-pushed
the
travis/extev-polls
branch
from
3e23d7f
to
c6ce981
Compare
andybalaam
suggested changes
Jan 14, 2022
andybalaam
approved these changes
Jan 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-js-sdk#2102
Builds on #7462
After this change, polls will support the full range of extensible events for both parsing and generation. The events-sdk has been specifically built to keep producing
m.textvariations of events though, for support with mobile's polls implementation.This additionally fixes some bugs with the implementation - some cases of invalid event were being counted as unrenderable when in fact they are spoiled or similar.
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://61e1ea929f4ef329164f83c5--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.