Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Scaled Creating Polls dialog box for small windows #8530

Closed
wants to merge 1 commit into from

Conversation

ankur12-1610
Copy link
Contributor

@ankur12-1610 ankur12-1610 commented May 7, 2022

Signed-off-by: ankur12-1610 anknerd.12@gmail.com

Fixes: vector-in/element-web/#21855

polls.mp4

Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Scaled Creating Polls dialog box for small windows (#8530). Contributed by @ankur12-1610.

Signed-off-by: ankur12-1610 <anknerd.12@gmail.com>
@ankur12-1610 ankur12-1610 requested a review from a team as a code owner May 7, 2022 22:56
@ankur12-1610
Copy link
Contributor Author

ankur12-1610 commented May 7, 2022

@t3chguy can you give a look at it? 😅

@SimonBrandner SimonBrandner added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label May 8, 2022
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2022-05-08_08-28

I think this would result in ^ (double scrollabars)

@ankur12-1610
Copy link
Contributor Author

ankur12-1610 commented May 8, 2022

2022-05-08_08-28

I think this would result in ^ (double scrollabars)

@SimonBrandner but I haven't changed anything related to scrollbars I've just played with footer of the dialog 🤔
And ig current element version has the same dialog box? or am I wrong?

@SimonBrandner
Copy link
Contributor

Then I am unsure as to how this PR improves the situation - the dialog still seems to behave unideally in small windows. What am I missing?

@ankur12-1610
Copy link
Contributor Author

ankur12-1610 commented May 8, 2022

Then I am unsure as to how this PR improves the situation - the dialog still seems to behave unideally in small windows. What am I missing?

In small windows the footer used to overlap over the content due to its absolute position and also there wasn't any background given to footer so as soon it overlapped the content in small windows the content was visible through the footer.

@SimonBrandner
Copy link
Contributor

Ah, I see - I am not sure if we would accept this as a bugfix for the mentioned issue as this only slightly changes the situation but the dialog still feels very much confusing/unusable

@SimonBrandner
Copy link
Contributor

Do you think you would be able to fix the other issue - mainly the scrolling weirdness?

@ankur12-1610
Copy link
Contributor Author

Do you think you would be able to fix the other issue - mainly the scrolling weirdness?

Yeah, but I'll need to recreate the dialog from the base cause there are two scrollable divs which are creating a little bit of problem :')

@ankur12-1610
Copy link
Contributor Author

Ah, I see - I am not sure if we would accept this as a bugfix for the mentioned issue as this only slightly changes the situation but the dialog still feels very much confusing/unusable

Ah! I just saw the issue and gave it a try was not sure end result will be significant or not 😅

@SimonBrandner
Copy link
Contributor

Do you think you would be able to fix the other issue - mainly the scrolling weirdness?

Yeah, but I'll need to recreate the dialog from the base cause there are two scrollable divs which are creating a little bit of problem :')

As long as that is the best way to fix the problem and we retain all the features, that would be ideal :)

@ankur12-1610
Copy link
Contributor Author

Do you think you would be able to fix the other issue - mainly the scrolling weirdness?

Yeah, but I'll need to recreate the dialog from the base cause there are two scrollable divs which are creating a little bit of problem :')

As long as that is the best way to fix the problem and we retain all the features, that would be ideal :)

Cool, then I'll create a new issue on resolving two scrollbars, is it okay?

@SimonBrandner
Copy link
Contributor

Do you think you would be able to fix the other issue - mainly the scrolling weirdness?

Yeah, but I'll need to recreate the dialog from the base cause there are two scrollable divs which are creating a little bit of problem :')

As long as that is the best way to fix the problem and we retain all the features, that would be ideal :)

Cool, then I'll create a new issue on resolving two scrollbars, is it okay?

Sure, go ahead

@ankur12-1610
Copy link
Contributor Author

@SimonBrandner I guess the current issue I'm working on is related to the scrolling weirdness, I'll make the changes to this PR itself rather than creating a new issue. Does that work?

@SimonBrandner
Copy link
Contributor

@SimonBrandner I guess the current issue I'm working on is related to the scrolling weirdness, I'll make the changes to this PR itself rather than creating a new issue. Does that work?

Sure!

@MadLittleMods MadLittleMods added the Z-Community-PR Issue is solved by a community member's PR label Jun 1, 2022
@gaelledel
Copy link

note: We should already have a component for this type of modal on the web
It should all be 100% opaque including the sticky footer

@Johennes
Copy link
Contributor

Johennes commented Jan 6, 2023

Since this seems abandoned, I opened #9873.

@turt2live
Copy link
Member

Closing in favour of #9873 - thanks for your contribution!

@turt2live turt2live closed this Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating polls does not scale well for small windows
6 participants