Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fixed misaligned reply preview in thread composer. #9733

Closed
wants to merge 1 commit into from
Closed

Fixed misaligned reply preview in thread composer. #9733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion res/css/views/rooms/_ReplyPreview.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ limitations under the License.
background: $background;
max-height: 50vh;
overflow: auto;
margin: 0 0 0 -8px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will shift the reply preview left by 8 pixels in all scenarios.
That might create a visual regression in the main room timeline too. Could you add some screenshots for that context too so we can validate whether it looks adequate.

We also tend to use $spacing-8 rather than hardcoding a value. calc(-1 * $spacing-8) should achieve the same result here


.mx_ReplyPreview_section {
border-bottom: 1px solid $primary-hairline-color;
Expand All @@ -39,7 +40,7 @@ limitations under the License.

.mx_ReplyPreview_header_cancel {
background-color: $primary-content;
mask: url('$(res)/img/cancel.svg');
mask: url("$(res)/img/cancel.svg");
mask-repeat: no-repeat;
mask-position: center;
mask-size: 18px;
Expand Down