This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Tests for AdvancedRoomSettingsTab #9994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
added
the
T-Task
dbkr
approved these changes
Jan 27, 2023
florianduros
approved these changes
Jan 27, 2023
|
|
||
| it("should display room ID", () => { | ||
| const tab = renderTab(); | ||
| tab.getByText(roomId); |
There was a problem hiding this comment.
An expect is missing here ?
There was a problem hiding this comment.
The test fails if getByText fails, so I think this is OK? Is there something I'm missing?
| mocked(room.getVersion).mockReturnValue("custom_room_version_1"); | ||
|
|
||
| const tab = renderTab(); | ||
| tab.getByText("custom_room_version_1"); |
There was a problem hiding this comment.
An expect is missing here ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is prep for MSC3946.
Part of element-hq/element-web#24322
This change is marked as an internal change (Task), so will not be included in the changelog.