Exhaustive sync_events::Response conversion #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to reduce compile times.
|
This whole thing would look less ugly once it's more directly supported with a lint that triggers on reachable rest patterns. I've opened rust-lang/rust#84332 for that. |
So the SDKs own SyncResponse type doesn't get out-of-sync.
|
This probably obsoletes #136 too. |
Well yes and no, yes in its current form. We still need a PR to include the encryption info and what not. |
|
Yes, of course :) Should I open an issue about that, as a replacement for ruma/ruma#35 and #136? |
|
I mean sure if you want to, though I can also just keep that in my head since I'll work on #136 this week. |
|
Okay, then I won't create an issue. I'm done force-pushing by the way 😅 |
|
Thanks, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I had to duplicate the entire destructuring statement for
sync_events::Responsesince attributes on field patterns or..rest-field patterns are not supported. (cc rust-lang/rust#81282 (comment))From here it should be easy to add
EncryptionInfoas discussed without further changes to Ruma, right? If so, this closes ruma/ruma#35.